This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH v2 4/4] Fix a FIXME in mi-out.c
- From: Tom Tromey <tromey at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at adacore dot com>
- Date: Tue, 2 Jul 2019 09:36:02 -0600
- Subject: [PATCH v2 4/4] Fix a FIXME in mi-out.c
- References: <20190702153602.27637-1-tromey@adacore.com>
This removes a FIXME comment from mi_ui_out::do_field_int, by
replacing a printf with a use of plongest.
gdb/ChangeLog
2019-07-02 Tom Tromey <tromey@adacore.com>
* mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
---
gdb/ChangeLog | 4 ++++
gdb/mi/mi-out.c | 5 +----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c
index dd99a2b7fb1..75e3f0313d8 100644
--- a/gdb/mi/mi-out.c
+++ b/gdb/mi/mi-out.c
@@ -98,10 +98,7 @@ void
mi_ui_out::do_field_int (int fldno, int width, ui_align alignment,
const char *fldname, int value)
{
- char buffer[20]; /* FIXME: how many chars long a %d can become? */
-
- xsnprintf (buffer, sizeof (buffer), "%d", value);
- do_field_string (fldno, width, alignment, fldname, buffer,
+ do_field_string (fldno, width, alignment, fldname, plongest (value),
ui_out_style_kind::DEFAULT);
}
--
2.20.1