This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[users/palves/format_strings] Down with .ptr() (Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output))
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 1 Jul 2019 20:24:34 +0100
- Subject: [users/palves/format_strings] Down with .ptr() (Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output))
- References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <b0299d9c-22d8-de30-72b5-99de4605d5dd@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <87wohx5hir.fsf@tromey.com> <ef92b0b9-11cc-57ce-9253-157161d58860@redhat.com> <4e543ef2-eec3-b82c-a84a-a107e1ef2bc2@redhat.com> <5df7a829-1cff-3df4-f2d3-92076cdc4699@redhat.com> <87imslpsxm.fsf@tromey.com>
On 7/1/19 6:26 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> static inline styled_string_s *
> Pedro> styled_string (const ui_file_style &style, const char *str,
> Pedro> styled_string_s &&tmp = {})
>
> Nice trick -- I hadn't seen that one before!
>
> Pedro> Here's a patch implementing the idea above. I wrote this a couple
> Pedro> weeks ago, and at the time I felt more strongly about it. Is this
> Pedro> worth it?
>
> Yes, I think so. It removes some clutter. The expense is that the call
> is tricky and can't be relied on outside of an argument list, really;
> but on the other hand I don't expect these things to be used elsewhere.
Yeah, if we ever need to instantiate one of these outside an argument
list, we can still instantiate a styled_string_s instead of
calling styled_string. But I also don't expect this to be ever necessary.
Alright, I merged this one to users/palves/format_strings.
Thanks,
Pedro Alves