This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541)


On Friday, June 28 2019, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> gdb/ChangeLog:
> Sergio> 2019-06-27  Sergio Durigan Junior  <sergiodj@redhat.com>
>
> Sergio> 	* gdbarch.c: Regenerate.
> Sergio> 	* gdbarch.h: Regenerate.
> Sergio> 	* gdbarch.sh: Add 'stap_adjust_register'.
> Sergio> 	* i386-tdep.c: Include '<unordered_set>'.
> Sergio> 	(i386_stap_adjust_register): New function.
> Sergio> 	(i386_elf_init_abi): Register 'i386_stap_adjust_register'.
> Sergio> 	* stap-probe.c (stap_parse_register_operand): Call
> Sergio> 	'gdbarch_stap_adjust_register'.
>
> Thank you for the patch and the excellent explanation.
>
> This is ok.

Thank you, Tom.

> For a while I was updating some SystemTap wiki page to link to these
> kinds of bugs, so that anybody else interested in supporting these
> probes had a list of oddities to work from.  This one would seem to
> qualify for that.

Good point.  I will edit
https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation and
include this bug for reference.

Pushed: 7d7571f0c14b4673ca95f6dc31d6f07d429e6697

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]