This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add an Objfile.lookup_global_symbol function
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Christian Biesinger <cbiesinger at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 26 Jun 2019 18:36:58 +0300
- Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function
- References: <20190625220832.247935-1-cbiesinger@google.com>
> Date: Tue, 25 Jun 2019 17:08:32 -0500
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2cc82e8656..e52af20748 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -36,6 +36,9 @@
> ** gdb.Type has a new property 'objfile' which returns the objfile the
> type was defined in.
>
> + ** gdb.Objfile has a new method 'lookup_global_symbol' to lookup a symbol
> + from this objfile only.
> +
> * New commands
This part is OK.
> +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]})
> +Searches for a global symbol by name in this objfile. Optionally, the
^^
Two spaces between sentences (here and elsewhere in the patch),
please.
The documentation part is OK with this nit fixed.
Thanks.