Re: [FYI] Fix crash when setting breakpoint condition

[Pedro Alves <palves at redhat dot com>]

On 6/19/19 1:06 PM, Tom Tromey wrote:
> +++ b/gdb/testsuite/gdb.ada/length_cond.exp
> @@ -0,0 +1,44 @@
> +# Copyright 2019 Free Software Foundation, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +load_lib "ada.exp"
> +

This is missing an intro comment mentioning what the testcase is about.

Should say something similar to "Test Ada breakpoint conditions
involving arrays lengths.", I suppose.

Thanks,
Pedro Alves

> +standard_ada_testfile length_cond
> +
> +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable debug] != "" } {
> +  return -1
> +}
> +
> +clean_restart ${testfile}
> +
> +set bp_location [gdb_get_line_number "BREAKPOINT" ${testdir}/length_cond.adb]
> +gdb_breakpoint length_cond.adb:$bp_location message
> +
> +# Resolving the conditional expression would cause a crash, so it's
> +# enough to just set the conditions.
> +