This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Instantiate a single source highlighter
On Tue, 2019-06-18 at 21:20 +0100, Pedro Alves wrote:
> > +/* The global source highlight object, or null if one was never
> > + constructed. This is stored here rather than in the class so that
> > + we don't need to include anything or do conditional compilation in
> > + source-cache.h. */
> > +#ifdef HAVE_SOURCE_HIGHLIGHT
> > +static srchilite::SourceHighlight *highlighter;
> > +#endif
> Should it be a unique_ptr so that valgrind doesn't complain about
> it leaking when gdb exits?
As highlighter is a global static variable,
when GDB exits, valgrind will consider the memory as reachable
and not a leak.
So, from only a valgrind point of view, there is no reason to have
GDB releasing this memory automatically when exiting.