This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix "list" when control characters are seen


On 6/18/19 4:29 PM, Tom Tromey wrote:
>>> static void foo (int x)
>>> /* !
>>> -   !
>>> +
> 
> Pedro> This seems pretty obscure without the context of the patch around.
> 
> Pedro> Should we add a comment here?
> 
> Good idea, how's this?

Looks great, thanks.

Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]