Re: [PATCH] Make gdb.base/index-cache.exp work with readnow board (PR 24669)

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2019-06-16 6:53 a.m., Tom de Vries wrote:
> On 15-06-19 03:29, Simon Marchi wrote:
>> The gdb.base/index-cache.exp test fails with the readnow board:
>>
>>   $ make check TESTS="gdb.base/index-cache.exp" RUNTESTFLAGS="--target_board=readnow"
>>   FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file was created
>>   FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: expected file is there
>>   FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: check index-cache stats
>>   FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache stats
>>
>> The problem is similar to what was fixed in
>>
>>   5a56d6a65f84 ("[gdb/testsuite] Fix index-cache.exp with cc-with-{gdb-index,debug-names}")
>>
>> In that commit, gdb.base/index-cache.exp was modified to account for the
>> fact that the index cache is not used when the binary already has an
>> embedded index.
>>
>> The same situation happens when GDB is started with the -readnow flag:
>> it bypasses indices and partial symbols.  So this patch updates the test
>> to also expect the index cache not to be used if -readnow is present in
>> $GDBFLAGS,
>>
> 
> Hi,
> 
> thanks for fixing this. LGTM.
> 
> Thanks,
> - Tom

Thanks for reporting, I am going to push it.

Simon