This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix cache dir resolving on Windows


> Date: Fri, 07 Jun 2019 10:36:39 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> CC: gdb-patches@sourceware.org
> 
> >    const char *home = getenv ("HOME");
> > +#ifdef _WIN32
> > +  if (home == nullptr)
> > +      home = getenv ("APPDATA");
> > +#endif
> >    if (home != NULL)
> >      {
> >        /* Make sure the path is absolute and tilde-expanded.  */
> 
> Thanks, this LGTM.

Actually, I see that we mention HOME on Windows in the manual, in a
footnote that's part of the "Startup" node.  I think we should
document this addition there.  Would you like to add a change to the
manual as well?

Thanks.

P.S. I see that you don't have a copyright assignment on file, which
means we are limited in the amount of changes we can accept from you.
Would you like to start the legal paperwork of assigning to the FSF
the copyright for your changes?  If so, I will send you the form to
fill.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]