This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] gdb/riscv: Don't error when decoding a 6 or 8 byte instruction
- From: John Baldwin <jhb at FreeBSD dot org>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Cc: Jim Wilson <jimw at sifive dot com>, Palmer Dabbelt <palmer at sifive dot com>
- Date: Tue, 4 Jun 2019 09:36:04 -0700
- Subject: Re: [PATCH] gdb/riscv: Don't error when decoding a 6 or 8 byte instruction
- References: <firstname.lastname@example.org>
On 6/4/19 4:50 AM, Andrew Burgess wrote:
> If the RISC-V prologue scanner finds a 6 or 8 byte instruction we
> currently throw an internal error, which is not great for the user.
> A mechanism already exists in the prologue scanner to leave
> instructions marked as unknown so that we can stop the prologue scan
> without raising an error, this is used for all 2 and 4 byte
> instructions that are not part of the small set the prologue scanner
> actually understands.
> This commit changes GDB so that all 6 and 8 byte instructions are
> marked as unknown, rather than causing an error.
Looks good to me.