This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdb/symtab] Fix symbol loading performance regression
- From: Tom Tromey <tom at tromey dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 29 May 2019 12:36:12 -0600
- Subject: Re: [PATCH][gdb/symtab] Fix symbol loading performance regression
- References: <20190513092700.GA9733@delia>
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> 2019-05-11 Tom de Vries <tdevries@suse.de>
Tom> PR symtab/24545
Tom> * symtab.c (struct demangled_name_entry): Add language field.
Tom> (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
Tom> static minimal symbol". Set and use language field.
Thanks for doing this.
Tom> + char *demangled_name = symbol_find_demangled_name (gsymbol,
Tom> + linkage_name_copy);
I think it would be better to do
gdb::unique_xmalloc_ptr<char> demangled_name (...);
and then adjust the code to use ".get ()" as needed.
This is ok with that change.
Tom