buildbot config cc-with-index not functional

[Tom de Vries <tdevries at suse dot de>]

[ was: Re: [committed][gdb/testsuite] Add cc-with-gdb-index.exp ]

Hi,

I've just added a target board cc-with-gdb-index.exp, to make it easy to
test using cc-with-tweaks.sh -i.

Then I stumbled upon the build bot config Fedora-x86_64-cc-with-index,
and I took a look at the test results.

I noticed that a test failing with cc-with-gdb-index.exp,
gdb.base/cache-index.exp (see PR24516 - "cc-with-gdb-index failures") is
passing in the cc-with-index config.

I managed to reproduce that pass using the way the config uses
cc-with-tweaks.sh:
...
$ make -k check \
  'CC_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i gcc' \
  'CXX_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i g++' \
  -j4 \
  FORCE_PARALLEL=1 \
  TS=1
...

So, AFAIU, the cc-with-index buildbot config does not actually test
using cc-with-tweaks.sh -i, as it intends to.

Thanks,
- Tom

On 03-05-19 12:58, Tom de Vries wrote:
> Hi,
> 
> Add a target board cc-with-gdb-index.exp, to make it easy to run cc-with-tweaks
> with CC_WITH_TWEAKS_FLAGS='-i'.
> 
> Tested on x86_64-linux.
> 
> Committed to trunk.
> 
> Thanks,
> - Tom
> 
> [gdb/testsuite] Add cc-with-gdb-index.exp
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-05-03  Tom de Vries  <tdevries@suse.de>
> 
> 	* boards/cc-with-gdb-index.exp: New file.
> 
> ---
>  gdb/testsuite/boards/cc-with-gdb-index.exp | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gdb/testsuite/boards/cc-with-gdb-index.exp b/gdb/testsuite/boards/cc-with-gdb-index.exp
> new file mode 100644
> index 0000000000..910e0acca1
> --- /dev/null
> +++ b/gdb/testsuite/boards/cc-with-gdb-index.exp
> @@ -0,0 +1,26 @@
> +# Copyright 2019 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# This file is a dejagnu "board file" and is used to run the testsuite
> +# with contrib/cc-with-tweaks.sh -i.
> +#
> +# Example usage:
> +# bash$ cd $objdir
> +# bash$ make check-gdb \
> +#   RUNTESTFLAGS='--target_board=cc-with-gdb-index'
> +#
> +
> +set CC_WITH_TWEAKS_FLAGS "-i"
> +load_board_description "cc-with-tweaks"
>