This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add "thread-exited" annotation
- From: Tom Tromey <tom at tromey dot com>
- To: Amos Bird <amosbird at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 30 Apr 2019 09:45:13 -0600
- Subject: Re: [PATCH] Add "thread-exited" annotation
- References: <87d0l8pzdz.fsf@gmail.com>
>>>>> "Amos" == Amos Bird <amosbird@gmail.com> writes:
Amos> This patch adds "thread-exited" annotation so that annotation based
Amos> clients like cgdb could currently handle thread exit.
I sort of wish that all clients would just use MI, but ...
Amos> +2019-04-26 Amos Bird <amosbird@gmail.com>
Amos> +
Amos> + * annotate.c (annotate_thread_exited): Add "thread-exited"
Amos> + annotation.
The patch itself is fine (just some nits), but a change like this
requires a documentation update (and probably NEWS as well) and a test
case.
Amos> +void
Amos> +annotate_thread_exited (struct thread_info *t, int silent)
Amos> +{
New functions should have an intro comment. Also, this function should
be "static".
Tom