This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] fix thread.c assertion after stepping past end of program
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 30 Apr 2019 09:33:49 -0600
- Subject: [RFC] fix thread.c assertion after stepping past end of program
We've run into an assertion failure when quitting GDB after stepping
past the end of a program that was linked with stripped libraries.
Here's how it's triggered, using a simple factorial example for
nios2-linux-gnu target with gdbserver:
Breakpoint 1, main () at /home/sandra/examples/fact.c:13
13 for (i = 0; i < 10; ++i) {
(gdb) advance 17
main () at /home/sandra/examples/fact.c:17
17 return 0;
(gdb) s
18 }
(gdb) s
0x2aaefffc in __libc_start_main ()
from
/./scratch/sandra/nios2-linux-spring-release/install/opt/codesourcery/nios2-linux-gnu/libc//lib/libc.so.6
(gdb) s
Single stepping until exit from function __libc_start_main,
which has no line number information.
[Inferior 1 (process 15772) exited normally]
You can't do that without a process to debug.
(gdb) s
The program is not being run.
(gdb) quit
/scratch/sandra/nios2-linux-fsf/obj/gdb-src-mainline-0-nios2-linux-gnu-x86_64-linux-gnu/gdb/inferior.c:287:
internal-error: inferior* find_inferior_pid(int): Assertion `pid != 0'
failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
The attached 1-liner patch fixes it and didn't cause regressions
elsewhere. However, I'm not sure if this is really where the bug is.
Maybe some other state is not getting cleaned out when the inferior
exits? WDYT?
-Sandra
diff --git a/gdb/thread.c b/gdb/thread.c
index 91741c7..c44b2b0 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -628,8 +628,8 @@ any_thread_of_inferior (inferior *inf)
{
gdb_assert (inf->pid != 0);
- /* Prefer the current thread. */
- if (inf == current_inferior ())
+ /* Prefer the current thread, if there is one. */
+ if (inf == current_inferior () && inferior_ptid != null_ptid)
return inferior_thread ();
for (thread_info *tp : inf->non_exited_threads ())