This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Support DW_FORM_strx1, _strx2, _strx3, _strx4 forms.
- From: Tom Tromey <tom at tromey dot com>
- To: "Ali Tamur via gdb-patches" <gdb-patches at sourceware dot org>
- Cc: Ali Tamur <tamur at google dot com>
- Date: Tue, 30 Apr 2019 08:30:14 -0600
- Subject: Re: [PATCH] Support DW_FORM_strx1, _strx2, _strx3, _strx4 forms.
- References: <CAH=Am=4ewPR4_VVVH4oj5GBNS-u-PdHivHEH5cXK9adj1NZ1Wg@mail.gmail.com>
>>>>> "Ali" == Ali Tamur via gdb-patches <gdb-patches@sourceware.org> writes:
Ali> Dwarf5 defines DW_FORM_strx1 and others, which are similar
Ali> to DW_FORM_strx but uses 1-4 bytes unsigned integers. This is
Ali> a small step towards supporting dwarf5 in gdb.
Thanks for doing this.
Ali> * gdb/testsuite/lib/dwarf.exp(): Added DW_FORM_strx1-4.
gdb/testsuite has its own ChangeLog, so this entry should go there.
Ali> +static unsigned int
Ali> +read_3_bytes (bfd *abfd, const gdb_byte *buf)
Normally in gdb, a new function should have an introductory comment. I
realize the other read_*_bytes functions don't have this, but that's
just a historical error.
The comment doesn't have to be very long.
This patch is ok with such a comment. Thanks.
Tom