This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Have 'thread|frame apply' style their output.
- From: Simon Marchi <simark at simark dot ca>
- To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>, Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 27 Apr 2019 15:19:43 -0400
- Subject: Re: [RFA] Have 'thread|frame apply' style their output.
- References: <20190309225932.14568-1-philippe.waroquiers@skynet.be> <874l6mcckt.fsf@tromey.com> <1556368938.22002.19.camel@skynet.be>
On 2019-04-27 8:42 a.m., Philippe Waroquiers wrote:
> Thanks for the review. Pushed after fixing (for the "const?" comment,
> I have added an explanation to clarify).
>
> Philippe
Hi Philippe,
There is one more spot to update, which you'll find if you build with --with-guile:
CXX guile/guile.o
/home/simark/src/binutils-gdb/gdb/guile/guile.c: In lambda function:
/home/simark/src/binutils-gdb/gdb/guile/guile.c:310:62: error: too few arguments to function ‘std::__cxx11::string execute_command_to_string(const char*, int, bool)’
to_string_res = execute_command_to_string (command, from_tty);
^
In file included from /home/simark/src/binutils-gdb/gdb/guile/guile.c:29:
/home/simark/src/binutils-gdb/gdb/gdbcmd.h:140:20: note: declared here
extern std::string execute_command_to_string (const char *p, int from_tty,
^~~~~~~~~~~~~~~~~~~~~~~~~
I presume you'll want to pass false in this case, since it's specifically meant to
send the output to a string, where we don't want styling?
Simon