This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/5] Fix memory leak in exception code

From: Tom Tromey <tromey at adacore dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org
Date: Thu, 25 Apr 2019 12:50:05 -0600
Subject: Re: [PATCH 5/5] Fix memory leak in exception code
References: <20190425165256.31226-1-tromey@adacore.com> <20190425165256.31226-6-tromey@adacore.com> <30e99361-c252-53e2-ec7c-5a6bc7301a3f@redhat.com> <87ef5qaqyn.fsf@tromey.com> <874l6m9btt.fsf@tromey.com> <1ee639e5-d431-4e79-63f4-0bf167790168@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> It seemed better than adding a global, thinking about threads, but now
Pedro> that I think a bit more about it, I realize that we won't ever be
Pedro> able to have multiple threads call into readline simultaneously -- it's
Pedro> full of global state.  So I'm fine with your patch as is, afterall.

Alright, I'll check in that version, after making the tweaks you
requested.

thanks,
Tom

References:
- [PATCH 0/5] More exception-handling improvements
  - From: Tom Tromey
- [PATCH 5/5] Fix memory leak in exception code
  - From: Tom Tromey
- Re: [PATCH 5/5] Fix memory leak in exception code
  - From: Pedro Alves
- Re: [PATCH 5/5] Fix memory leak in exception code
  - From: Tom Tromey
- Re: [PATCH 5/5] Fix memory leak in exception code
  - From: Tom Tromey
- Re: [PATCH 5/5] Fix memory leak in exception code
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]