This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 00/14] Add a type-safe API to registries
- From: John Baldwin <jhb at FreeBSD dot org>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 23 Apr 2019 16:11:28 -0700
- Subject: Re: [PATCH 00/14] Add a type-safe API to registries
- References: <20190423020955.17356-1-tom@tromey.com>
On 4/22/19 7:09 PM, Tom Tromey wrote:
> This series adds an optional type-safe API to the gdb registry
> feature, and converts various modules to use it.
>
> I don't think this is the final form for registries -- in the long run
> I suppose I'd like to turn them into a CRTP mixin class. However,
> this series seems like a reasonable step along the way, providing type
> safety and using policy classes for destruction.
>
> Let me know what you think.
>
> Regression tested by the buildbot.
I looked a few of these over and think it's an improvement. Do existing
keys still work btw? I know fbsd-tdep.c has a progspace key to cache
info needed to resolve TLS variables. It also has gdbarch data used to
cache the generated type for $_siginfo. I don't mind converting them
myself if the changes support both the old and new styles for now.
--
John Baldwin