This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Testsuite: Remove pie from trace tests
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Alan Hayward <Alan dot Hayward at arm dot com>
- Date: Thu, 18 Apr 2019 15:08:29 -0700
- Subject: Re: [PATCH] Testsuite: Remove pie from trace tests
- References: <20190410122539.91815-1-alan.hayward@arm.com>
On Wed, 10 Apr 2019 12:25:43 +0000
Alan Hayward <Alan.Hayward@arm.com> wrote:
> [I don't know enough about tracing to know if this is a bug or
> expected behaviour. If this is a bug then maybe we should add
> some additional pie specific tests, along with a bugzilla entry?
> Either way, seems sensible to me to disable pie for the existing
> tests given that they were never written with pie in mind?]
>
> Ubuntu/Debian defaults PIE to enabled. This causes the trace tests
> to fall over due to variables being returned as "unavailable". The
> tests were never designed to work with pie.
>
> Simply ensure the nopie flag is always used for the failing tests.
>
> This removes 100+ failures when running native-gdbserver on Ubuntu 18.04.
>
> gdb/testsuite/ChangeLog:
>
> 2019-04-10 Alan Hayward <alan.hayward@arm.com>
>
> * gdb.trace/backtrace.exp: Use nopie flag.
> * gdb.trace/circ.exp: Likewise.
> * gdb.trace/collection.exp: Likewise.
> * gdb.trace/ftrace.exp: Likewise.
> * gdb.trace/mi-trace-unavailable.exp: Likewise.
> * gdb.trace/mi-traceframe-changed.exp: Likewise.
> * gdb.trace/qtro.exp: Likewise.
> * gdb.trace/read-memory.exp: Likewise.
> * gdb.trace/report.exp: Likewise.
> * gdb.trace/tfile.exp: Likewise.
> * gdb.trace/tfind.exp: Likewise.
> * gdb.trace/unavailable.exp: Likewise.
LGTM.
Kevin