This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature

From: Pedro Alves <palves at redhat dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
Date: Thu, 18 Apr 2019 18:08:17 +0100
Subject: Re: [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature
References: <cover.1555455013.git.andrew.burgess@embecosm.com> <5cbfdd5672b59422d41f4b3c0ca20a9d45c20442.1555455013.git.andrew.burgess@embecosm.com>

Excellent.  I have no further comments on this version, except for ...

On 4/17/19 12:06 AM, Andrew Burgess wrote:

> +/* See valprint.h.  */
> +
> +bool val_print_check_max_depth (struct ui_file *stream, int recurse,
> +				const struct value_print_options *options,
> +				const struct language_defn *language)

... line break after the bool.

Thanks,
Pedro Alves

References:
- [PATCHv2 0/5] Add new 'print max-depth' feature
  - From: Andrew Burgess
- [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]