This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global


(I should have read this thread before replying on the other one.)

On 4/17/19 11:17 PM, Joel Brobecker wrote:
> 
>   - patch #3 (master only): Tag the main thread, and silence
>     the thread-exit notification of the thread that got tagged.
>     Depending on the implementation, this patch would potentially
>     be acceptable for 8.3, but might need extra work to apply.
>     I think we've had enough problems with 8.3 as it is, I don't
>     want to add more things to do, so I vote OUT for 8.3.

This doesn't seem right to me, given that the main thread may
legitimately exit before other threads.  If this approach is taken,
maybe tweak it a bit:

silence the thread-exit notification of the thread that got tagged
_iff there are no other threads in the process_.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]