This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 2/2] MI: Add new command -complete
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Vrany <jan dot vrany at fit dot cvut dot cz>, gdb-patches at sourceware dot org
- Date: Thu, 18 Apr 2019 15:14:59 +0100
- Subject: Re: [PATCH v4 2/2] MI: Add new command -complete
- References: <20190128124101.26243-1-jan.vrany@fit.cvut.cz> <20190418115847.19854-3-jan.vrany@fit.cvut.cz>
This version is OK, with the tiny issue below addressed.
Can you push this yourself, or do you need someone to do it for you?
> +/* Implement the "-complete" command. */
> +
> +void
> +mi_cmd_complete (const char *command, char **argv, int argc)
> +{
> + if (argc != 1)
> + error (_("Usage: -complete COMMAND"));
> +
> + if (max_completions == 0)
> + error (_("max-completions is zero, completion is disabled.\n"));
errors should not end in \n.
Thanks,
Pedro Alves