This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[FYI] Make "msg" const in internal_vproblem
- From: Tom Tromey <tromey at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at adacore dot com>
- Date: Thu, 11 Apr 2019 13:01:38 -0600
- Subject: [FYI] Make "msg" const in internal_vproblem
I noticed that the "msg" variable in internal_vproblem could be
"const". This seems like an improvement because it can wind up in
rodata.
Tested by rebuilding.
gdb/ChangeLog
2019-04-11 Tom Tromey <tromey@adacore.com>
* utils.c (internal_vproblem): Make "msg" const.
---
gdb/ChangeLog | 4 ++++
gdb/utils.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/utils.c b/gdb/utils.c
index 840779a6307..700f54f9ad3 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -300,7 +300,7 @@ internal_vproblem (struct internal_problem *problem,
/* Don't allow infinite error/warning recursion. */
{
- static char msg[] = "Recursive internal problem.\n";
+ static const char msg[] = "Recursive internal problem.\n";
switch (dejavu)
{
--
2.20.1