This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command

From: Pedro Alves <palves at redhat dot com>
To: Simon Marchi <simon dot marchi at efficios dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
Date: Tue, 9 Apr 2019 17:30:53 +0100
Subject: Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command
References: <20190409025557.28846-1-simon.marchi@polymtl.ca> <cdd9058b-e6d4-e2f1-4a1e-399571e0d2d8@redhat.com> <e5e172dc-56e9-4469-d900-5affcf025824@efficios.com>

On 4/9/19 5:19 PM, Simon Marchi wrote:

> I had initially changed start.exp to test both C and C++, then decided to just
> keep C++ for simplicity.  But your point about coverage is good, so I've done
> as you suggested.
> 

Thanks.

> gdb/ChangeLog:
> 
> 	* infcmd.c (run_command_1): Pass -qualified to tbreak when usind
> 	the "start" command.

Typo "usind".

> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/start-cpp.exp: New file.
> 	* gdb.base/start-cpp.cc: New file.

Note start-cpp.cc wasn't included in this patch -- don't forget
to git add it.

Otherwise OK.

Thanks,
Pedro Alves

Follow-Ups:
- Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command
  - From: Simon Marchi

References:
- [PATCH] Use -qualified flag when setting temporary breakpoint in start command
  - From: Simon Marchi
- Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command
  - From: Pedro Alves
- Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]