This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Some gdb_exception{,error,quit} tweaks
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Mon, 08 Apr 2019 11:53:00 -0600
- Subject: Re: [PATCH] Some gdb_exception{,error,quit} tweaks
- References: <20190408172425.31039-1-palves@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Thanks. This looks good to me.
Pedro> + gdb_exception (enum return_reason r, enum errors e,
Pedro> + const char *fmt, va_list ap)
Pedro> + : reason (r),
Pedro> + error (e),
Pedro> + message (std::make_shared<std::string> (string_vprintf (fmt, ap)))
I think these constructors should probably have ATTRIBUTE_PRINTF with 0
as the "first-to-check" parameter, like string_vprintf itself.
Tom