This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Sort #includes in gdb
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 03 Apr 2019 14:11:13 -0600
- Subject: Re: [RFC] Sort #includes in gdb
- References: <87fttfmnpq.fsf@tromey.com> <e132876c-15b3-7c47-f765-5c2db103b38e@redhat.com> <878sygydob.fsf@tromey.com> <87r2b7viht.fsf@tromey.com> <f172a298-809a-d928-9f5f-f65300826be2@redhat.com> <875zs1csim.fsf@tromey.com> <d077cc5fe3eb77bdb85ffa2ec2ca306c@polymtl.ca> <898eb4d9-9c21-9dee-0291-ce82251e6c42@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 03/29/2019 09:05 PM, Simon Marchi wrote:
>>
>> I don't think I've mentioned it, but I really like this change. I don't like the mental weight of having to choose where to add my include in an unorganized list :).
Pedro> Me too. I'm waiting for this to land before touching the "namespace gdb"
Pedro> work again, since a not-insignificant part of that work revolves around
Pedro> moving "#include"s in the middle of files to the top of the file.
This patch doesn't touch those includes -- it only touches the ones at
the top of a file. If you want to land yours first, it's no trouble for
me. The change is just running a script.
On irc the other day, Simon had the idea that I could land the patch in
pieces: say, convert [a-f]*, test that, check it in. I modified my
script to let me do this and the first batch went through. So, if you'd
really rather this go first, let me know and I can do it that way. It
may take a few days to get it all in.
Tom