This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, nios2] fix stepping past unwritable kernel helper
- From: Pedro Alves <palves at redhat dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, qiyao at sourceware dot org
- Date: Thu, 28 Mar 2019 11:39:30 +0000
- Subject: Re: [patch, nios2] fix stepping past unwritable kernel helper
- References: <80464f56-fccb-0bb4-dcdd-6a547e5418b0@codesourcery.com>
On 03/28/2019 04:47 AM, Sandra Loosemore wrote:
> +static int
> +nios2_linux_is_kernel_helper (CORE_ADDR pc)
> +{
> + return pc == 0x1004;
> +}
> +
> + /* Returns true if PC points to a kernel helper function. */
> + int (*is_kernel_helper) (CORE_ADDR pc);
Nit: please make these return bool instead of int.
Thanks,
Pedro Alves