This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[OBV][PATCH] Testsuite: Ensure interrupt-daemon-attach doesn't run forever
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: "sergiodj at redhat dot com" <sergiodj at redhat dot com>, nd <nd at arm dot com>, Alan Hayward <Alan dot Hayward at arm dot com>
- Date: Wed, 27 Mar 2019 11:50:30 +0000
- Subject: [OBV][PATCH] Testsuite: Ensure interrupt-daemon-attach doesn't run forever
[Pushed because this was slowing down the Aarch64 buildbot.
Sergio - it's probably worth checking if there are similar hanging processes on
the other buildslave machines.]
Looking at the AArch64 buildbot, I noticed about two dozen old instances of
interrupt-daemon-attach taking up a full 100% cpu each.
If the test fails then the test binary relies on an alarm to ensure it dies
after 60 seconds.
As per the Linux man page for alarm:
Alarms created by alarm() ... are not inherited by children created via fork.
Update the test to add an alarm in the child and also put a sleep in the
child loop so it does not constantly consume cpu.
Note I haven't managed to re-create why the test failed. This fix will just
stop it hanging and consuming cpu when it does.
gdb/testsuite/ChangeLog:
2019-03-27 Alan Hayward <alan.hayward@arm.com>
* gdb.base/interrupt-daemon-attach.c (main): Add alarm and sleep
in child.
---
gdb/testsuite/gdb.base/interrupt-daemon-attach.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.base/interrupt-daemon-attach.c b/gdb/testsuite/gdb.base/interrupt-daemon-attach.c
index 5dc84438dc..e8dddf81b4 100644
--- a/gdb/testsuite/gdb.base/interrupt-daemon-attach.c
+++ b/gdb/testsuite/gdb.base/interrupt-daemon-attach.c
@@ -43,6 +43,7 @@ main ()
break;
default:
+ /* In parent process. */
while (1)
{
marker ();
@@ -50,12 +51,18 @@ main ()
}
}
+ /* In child process. */
+
+ /* Alarms are not inherited by child processes. Set the alarm again to stop
+ the test case running forever. */
+ alarm (60);
+
/* Detach from controlling terminal. */
if (setsid () == (pid_t) -1)
return 1;
- for (;;)
- ;
+ while (1)
+ usleep (1000);
return 0;
}
--
2.20.1 (Apple Git-117)