This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [OBV][PATCH] Fix powerpc build

From: Alan Hayward <Alan dot Hayward at arm dot com>
To: Kevin Buettner <kevinb at redhat dot com>
Cc: GDB Patches <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
Date: Wed, 27 Mar 2019 08:42:30 +0000
Subject: Re: [OBV][PATCH] Fix powerpc build
References: <20190326171745.96435-1-alan.hayward@arm.com> <20190326155651.2bf97838@f29-4.lan>

> On 26 Mar 2019, at 22:56, Kevin Buettner <kevinb@redhat.com> wrote:
> 
> On Tue, 26 Mar 2019 17:17:55 +0000
> Alan Hayward <Alan.Hayward@arm.com> wrote:
> 
>> gdb/ChangeLog:
>> 
>> 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
>> 
>>        * ppc-linux-nat.c: Add include
> 
> The ChangeLog entry needs a period.

Thankfully I spotted that after I sent the email, but before I pushed.
It’s fixed in the actual commit.


>  It'd also be nice to mention
> what you're including.  I.e.
> 
> 	* ppc-linux-nat.c (linux-tdep.h): Add include.

Will do in future.


Alan.


> 
> Kevin

Follow-Ups:
- Re: [OBV][PATCH] Fix powerpc build
  - From: Andreas Schwab

References:
- [OBV][PATCH] Fix powerpc build
  - From: Alan Hayward
- Re: [OBV][PATCH] Fix powerpc build
  - From: Kevin Buettner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]