This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] gdb/testsuite: Make test names unique in gdb.python/py-prettyprint.exp

From: Tom Tromey <tom at tromey dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 25 Mar 2019 09:18:05 -0600
Subject: Re: [PATCH 2/3] gdb/testsuite: Make test names unique in gdb.python/py-prettyprint.exp
References: <cover.1553382150.git.andrew.burgess@embecosm.com> <6398e1704bab8844536849ff3829b3eb34bf5b24.1553382150.git.andrew.burgess@embecosm.com>

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> This makes the test names unique in gdb.python/py-prettyprint.exp, it
Andrew> also switches to use gdb_breakpoint and gdb_continue_to_breakpoint
Andrew> more so that we avoid test names with the source line number in - this
Andrew> is bad if the test source ever changes as the test names will then
Andrew> change.

Thanks for doing this.  This looks good to me.

Tom

References:
- [PATCH 0/3] Pretty Printing Whitespace And Python Pretty Printing API
  - From: Andrew Burgess
- [PATCH 2/3] gdb/testsuite: Make test names unique in gdb.python/py-prettyprint.exp
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]