This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] More block constification

On Fri, 22 Mar 2019 23:51:42 -0600
Tom Tromey <tom@tromey.com> wrote:

LGTM, except for one nit...

> diff --git a/gdb/eval.c b/gdb/eval.c
> index 0c0cf7f6ac7..a431ce453dc 100644
> --- a/gdb/eval.c
> +++ b/gdb/eval.c
> @@ -123,7 +123,7 @@ parse_and_eval (const char *exp)
>  struct value *
>  parse_to_comma_and_eval (const char **expp)
>  {
> -  expression_up expr = parse_exp_1 (expp, 0, (struct block *) 0, 1);
> +  expression_up expr = parse_exp_1 (expp, 0, 0, 1);
>  
>    return evaluate_expression (expr.get ());
>  }

Pass NULL or nullptr instead of 0.

Kevin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]