This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] gdb: Make python display_hint None handling defined behaviour
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Sat, 23 Mar 2019 23:04:44 +0000
>
> The documentation say that the display_hint method must return a
> string to serve as a display hint, and then goes on to list some
> acceptable strings.
>
> However, if we don't supply the display_hint method then we get a
> default display style behaviour and there's currently no way (in the
> python api) to force this default behaviour.
>
> The guile api allows #f to be used in order to force the default
> display style behaviour, and this is documented.
>
> Currently, using None in the python api also forces the default
> display behaviour.
>
> This commit extends the documentation to make returning None from the
> display_hint method and official mechanism by which the user can get
> the default display style.
>
> I've extended one of the existing tests to cover this case.
>
> gdb/doc/ChangeLog:
>
> * python.texi (Pretty Printing API): Document use of None for the
> display_hint.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.python/py-prettyprint.c (struct container) <is_map_p>: New
> field.
> (make_container): Initialise new field.
> * gdb.python/py-prettyprint.exp: Add new tests.
> * gdb.python/py-prettyprint.py (class ContainerPrinter)
> <display_hint>: New method.
The documentation part is OK.
Thanks.