This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows

From: Владимир Мартьянов <vilgeforce at gmail dot com>
To: gdb-patches at sourceware dot org
Date: Sat, 23 Mar 2019 14:59:05 +0300
Subject: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows

The fourth argument of FormatMessage() in strwinerror() in file
win32-low.c is set to zero. Thus, Windows could use system default
locale to translate error codes to error message. At the same time,
gdbserver have hardcoded English error messages ("Error creating
process..." for example). As a result, server could display error
messages with mixed languages.

I made a patch to use en_US locale in FormatMessage, so all error
messages will be in English.

Changelog and patch files are attached

Attachment: Changelog.24377
Description: Binary data

Attachment: 0001-Fix-mixing-English-and-system-default-languages-in-e.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]