This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 3/8] AArch64: Read pauth registers

From: Simon Marchi <simark at simark dot ca>
To: Alan Hayward <Alan dot Hayward at arm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Cc: nd <nd at arm dot com>
Date: Thu, 21 Mar 2019 16:56:22 -0400
Subject: Re: [PATCH v2 3/8] AArch64: Read pauth registers
References: <20190306133325.2531-1-alan.hayward@arm.com> <20190306133325.2531-4-alan.hayward@arm.com>

On 2019-03-06 8:33 a.m., Alan Hayward wrote:

@@ -445,6 +473,11 @@ aarch64_linux_nat_target::fetch_registers (struct regcache *regcache,
      fetch_sveregs_from_thread (regcache);
    else
      fetch_fpregs_from_thread (regcache);
+
+  if (tdep->has_pauth ())
+    if (regno == AARCH64_PAUTH_DMASK_REGNUM (tdep->pauth_reg_base)
+	|| regno == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base))
+      fetch_pauth_masks_from_thread (regcache);
  }


Just this nit:

The "outer" if should have curly braces.

Ref:https://www.gnu.org/prep/standards/html_node/Syntactic-Conventions.html#Syntactic-Conventions


Simon

References:
- [PATCH v2 0/8] Support for AArch64 Pointer Authentication
  - From: Alan Hayward
- [PATCH v2 3/8] AArch64: Read pauth registers
  - From: Alan Hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]