This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Readline: Cleanup some warnings
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Tom Tromey <tom at tromey dot com>
- Cc: palves at redhat dot com, gdb-patches at sourceware dot org
- Date: Tue, 19 Mar 2019 20:36:33 +0200
- Subject: Re: [PATCH] Readline: Cleanup some warnings
- References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> <F71F4EDA-CBDF-4B05-B9C2-588D02471EB2@arm.com> <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> <20190201080533.GA31043@adacore.com> <877eejvfoq.fsf@tromey.com> <1549047248.2630.7.camel@skynet.be> <310315f8-62ab-2eff-042f-9f2ae9de07da@redhat.com> <87wokxtnlt.fsf@tromey.com> <83h8c1wdr5.fsf@gnu.org> <87imwex333.fsf@tromey.com>
> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>, palves@redhat.com, gdb-patches@sourceware.org
> Date: Tue, 19 Mar 2019 10:04:48 -0600
>
> >> I still don't really know what to do about the readline-related hack in
> >> the mingw gdb_select. I'd like to remove it, but I can't test it and I
> >> don't know whether it's still needed.
>
> Eli> Can someone point me to the PR that led to that hack? I'd like to see
> Eli> what happens in that use case and why is this code needed to solve it.
> Eli> (I tried "git annotate", but that didn't tell me anything interesting
> Eli> about the history of that snippet. Apologies if I missed something.)
>
> All I know is what annotate says. The commit message is appended.
Yes, thanks. I've seen that, of course, but the log is uninformative.
> Here's the gdb-patches thread about it:
>
> https://sourceware.org/ml/gdb-patches/2008-02/msg00423.html
Thanks, I will study that. Hopefully, it will allow me to understand
more about the issue.