This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Fix first time you type UP or DOWN in TUI's command window (Re: [RFC 8.3 0/3] Some style fixes)


On 03/19/2019 06:08 AM, Eli Zaretskii wrote:
>> Cc: tromey@adacore.com, gdb-patches@sourceware.org
>> From: Pedro Alves <palves@redhat.com>

>> Anyway, I've stared at this for a while, and I _think_ this captures
>> the idea.  WDYT?
> 
> Thanks, LGTM.  It certainly explains the values of these two members
> and how they are used.
> 
>> +	{
>> +	  /* If we've reached the end of the line, so go back to
>> +	     letting text output go to the console.  */
> 
> A minor typo: "If ..., so ..." sounds weird.  I think you wanted to
> get rid of that "If".

Indeed.  Fixed that, and merged to master.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]