This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MinGW build failure for GDB 8.2.90 with source-highlight
> Date: Tue, 12 Mar 2019 12:29:48 -0400
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: gdb-patches@sourceware.org, palves@redhat.com
>
> > diff --git a/gdb/source-cache.c b/gdb/source-cache.c
> > index 097c8a3..b98272c 100644
> > --- a/gdb/source-cache.c
> > +++ b/gdb/source-cache.c
> > @@ -23,6 +23,8 @@
> > #include "cli/cli-style.h"
> >
> > #ifdef HAVE_SOURCE_HIGHLIGHT
> > +#undef open
> > +#undef close
> > #include <fstream>
> > #include <sstream>
> > #include <srchilite/sourcehighlight.h>
>
> Thanks, this is fine with me, maybe with a comment explaining why it's
> needed. I also think you could push it to the master branch, so that it
> builds for mingw users.
Done, on both counts.
Thanks for the review.