Re: [RFC 8.3 0/3] Some style fixes

["Hannes Domani via gdb-patches" <gdb-patches at sourceware dot org>]

 Am Dienstag, 12. März 2019, 17:48:12 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben: 

> >>>>> "Hannes" == Hannes Domani via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes> 1) Outside of TUI, escaped characters (< 040 and 0177) aren't handled correctly any more when
> Hannes> list'ing some source code, resulting in an endless loop.
> Hannes> See print_source_lines_base(), I just added "++iter" in the last 2 if() blocks, that fixed it for me.
>
> Hannes> 2) In TUI, scrolling right with the arrow keys, the first keypress doesn't do anything.
> Hannes> (that's just a very minor nuisance)
>
> Hannes> 3) Again in TUI, scrolling right handles TABS and escaped characters as single characters,
> Hannes> which just looks weird.
>
> Thanks, I will take a look at these.
>
> I suspect #2 is the nonl problem.  Could you try the patch I sent in
> another branch of this thread?

No, applying that doesn't fix this.
In copy_source_line() it checks if (column < first_col), and because of the ++column directly
before, it basically starts with 1 instead of 0.

Attached is a patch that fixes most of 2) and 3), but I ignored the handling of escaped
characters, because I just don't have them in any of my sources.

Attachment: 0001-Fix-scrolling-right-in-TUI.patch
Description: Binary data