This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 06.03.2019 1:10, Tom Tromey wrote: > LRN writes: >> 2019-02-28 Руслан Ижбулатов <lrn1986@gmail.com> >> >> * source.c (find_and_open_source): Apply substitute-path to all >> filenames, both absolute and relative > > Is it possible to get a test case for the patch? No. I couldn't find a gdb testcase for the substitute-path feature (there's one that checks issuing the `set substitute-path` command itself, but it doesn't seem to be testing its *runtime effect*, i.e. how it is applied when gdb needs to read a source file), so i can't provide a test case for this change by modifying an existing one. That means i'd have to write one from scratch, and i wouldn't know how to even begin to do that. Also, running gdb testsuite requires dejagnu, which i don't have (and by "i don't have" i mean "i've never built it from the source", as this is how i get 90% of all my dev software). It should technically be possible for me to build it, but that'll take time that i would rather spend on other things. >> gdb::unique_xmalloc_ptr<char> rewritten_filename; > [...] >> + rewritten_filename = rewrite_source_path (filename); > > I think these two lines can now be joined; no need to have a separate > assignment. > New version of the patch is attached.
Attachment:
0001-Apply-substitute-path-to-relative-filenames-as-well.patch
Description: Text document
Attachment:
signature.asc
Description: OpenPGP digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |