This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/16] Add styling to the gdb CLI and TUI


>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> Here's a working prototype I'm currently testing.  If this
Eli> implementation strategy is acceptable, I will post a proper patch
Eli> soon.

It looks reasonable to me.

Eli> +	  if (fg.is_none ())
Eli> +	    fgcolor = norm_attr & 15;
Eli> +	  else
Eli> +	    fgcolor = fg_color[fg.get_value () & 15];

get_value is only defined for basic colors; you'll get an assertion here
if the color is not basic.  For non-basic colors, you can get the rgb
values for the color instead via the get_rgb method.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]