This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] Fix BFD leak in solib-darwin.c

From: Tom Tromey <tromey at adacore dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org
Date: Mon, 25 Feb 2019 06:51:07 -0700
Subject: Re: [RFC] Fix BFD leak in solib-darwin.c
References: <20190222163645.9349-1-tromey@adacore.com> <49527b82-328e-e129-21d1-cbc333c70ca7@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 02/22/2019 04:36 PM, Tom Tromey wrote:
>> if (sub != NULL)
>> dyld_bfd = sub;
>> else
>> -	dyld_bfd.release ();
>> +	dyld_bfd.reset (nullptr);

Pedro> These 4 lines are now equivalent to just doing:

Pedro>    dyld_bfd = sub;

I made this change and I'm going to commit it shortly.

Tom

References:
- [RFC] Fix BFD leak in solib-darwin.c
  - From: Tom Tromey
- Re: [RFC] Fix BFD leak in solib-darwin.c
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]