This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] AArch64: Add default reggroups
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Alan Hayward <Alan dot Hayward at arm dot com>
- Date: Tue, 19 Feb 2019 17:02:27 -0700
- Subject: Re: [PATCH] AArch64: Add default reggroups
- References: <20190213140303.8848-1-alan.hayward@arm.com>
On Wed, 13 Feb 2019 14:03:08 +0000
Alan Hayward <Alan.Hayward@arm.com> wrote:
> Aarch64 does not define any reggroups. This causes "maintenance print
> reggroups" to dump the default set (which is ok).
>
> However, if a new group is added via an xml file, then this now becomes
> the only group.
>
> Fixes gdb.xml/tdesc-regs.exp on AArch64.
>
> gdb/ChangeLog:
>
> 2019-02-13 Alan Hayward <alan.hayward@arm.com>
>
> * aarch64-tdep.c (aarch64_add_reggroups): New function
> (aarch64_gdbarch_init): Call aarch64_add_reggroups.
The first line of your ChangeLog entry needs a period.
Otherwise, LGTM.
Kevin