This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix error message and use-after-free on errors in nested source files

From: Kevin Buettner <kevinb at redhat dot com>
To: gdb-patches at sourceware dot org
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>
Date: Tue, 19 Feb 2019 16:51:30 -0700
Subject: Re: [PATCH] Fix error message and use-after-free on errors in nested source files
References: <20190218234640.25664-1-simon.marchi@polymtl.ca> <20190219153729.35348891@f29-4.lan> <7eed7ae3-6f2a-285b-1270-6006d524e87a@ericsson.com>

On Tue, 19 Feb 2019 23:24:01 +0000
Simon Marchi <simon.marchi@ericsson.com> wrote:

> > Did you mean to remove gdb_exit above?  If so, why?  
> 
> Yes, many tests have a gdb_exit at the end.  I believe this is not necessary (though it doesn't hurt)
> because it's done anyway after the execution of the test.  So it has become an automatism to remove
> it if I am modifying that area of the tests.  I can leave it there if you prefer.

Thanks for the explanation.

> Thanks for the review, here's the updated version.  I also fixed the title,
> where it should read "sourced" instead of "source".

LGTM.

Kevin

Follow-Ups:
- Re: [PATCH] Fix error message and use-after-free on errors in nested source files
  - From: Simon Marchi

References:
- [PATCH] Fix error message and use-after-free on errors in nested source files
  - From: Simon Marchi
- Re: [PATCH] Fix error message and use-after-free on errors in nested source files
  - From: Kevin Buettner
- Re: [PATCH] Fix error message and use-after-free on errors in nested source files
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]