This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Sort #includes in gdb
- From: Tom Tromey <tom at tromey dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 15 Feb 2019 13:46:01 -0700
- Subject: Re: [RFC] Sort #includes in gdb
- References: <87fttfmnpq.fsf@tromey.com> <20190127045818.GA15682@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> It might be FUD on my part, but with C & C++, I've always been very
Joel> nervous about changing the order of #include-s. This is because some
Joel> headers sometimes define the same macros with different values, and
Joel> so order can make a difference for those (without really knowing
Joel> which is more correct, if any, and whether we are in fact getting
Joel> the one that we should). And of course, this is all highly platform-
Joel> dependent.
Yeah, it's a concern; though I already pushed a series that fixes the
fallout from the first draft of this series. Basically it was some
minor latent bugs. I'll answer a bit more in reply to Pedro's note.
Joel> I really like, however, the idea of overcoming that fear, and
Joel> evaluate in practice what the real impact of order is. But since
Joel> we are getting close to 8.3 branching, could we hold the actual
Joel> puth until after the 8.3 branch is created?
Definitely.
Tom