This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use new Darwin operating system names
- From: Kevin Buettner <kevinb at redhat dot com>
- To: binutils at sourceware dot org, Saagar Jha <saagar at saagarjha dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 14 Feb 2019 19:13:25 -0700
- Subject: Re: [PATCH] Use new Darwin operating system names
- References: <E1F08FC0-B475-4855-AD95-F65515838599@saagarjha.com>
On Fri, 26 Oct 2018 21:57:37 -0700
Saagar Jha <saagar@saagarjha.com> wrote:
> Replace MacOSX with macOS, IOS with iOS, and WatchOS with watchOS.
>
> ChangeLog:
> 2018-10-26 Saagar Jha <saagar@saagarjha.com>
>
> * include/mach-o/loader.h: Use new OS names.
A couple of nits regarding the ChangeLog entry...
1) This entry should go in include/ChangeLog, so you don't need to
have the include/ prefix.
2) Please adjust it to indicate that only the comments are affected.
Like this, perhaps:
* mach-o/loader.h: Use new OS names in comments.
Otherwise, it looks good to me.
I wish I could tell you to check this in, but I think that the
binutils maintainers will need to approve this change. I've added
binutils@sourceware.org to the "To:" header in my reply.
Thanks,
Kevin
> ---
> include/mach-o/loader.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/mach-o/loader.h b/include/mach-o/loader.h
> index c075a8e023..2c02102c9f 100644
> --- a/include/mach-o/loader.h
> +++ b/include/mach-o/loader.h
> @@ -174,8 +174,8 @@ typedef enum bfd_mach_o_load_command_type
> BFD_MACH_O_LC_ENCRYPTION_INFO = 0x21, /* Encrypted segment info. */
> BFD_MACH_O_LC_DYLD_INFO = 0x22, /* Compressed dyld information. */
> BFD_MACH_O_LC_LOAD_UPWARD_DYLIB = 0x23, /* Load upward dylib. */
> - BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal MacOSX version. */
> - BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal IOS version. */
> + BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal macOS version. */
> + BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal iOS version. */
> BFD_MACH_O_LC_FUNCTION_STARTS = 0x26, /* Compressed table of func start. */
> BFD_MACH_O_LC_DYLD_ENVIRONMENT = 0x27, /* Env variable string for dyld. */
> BFD_MACH_O_LC_MAIN = 0x28, /* Entry point. */
> @@ -185,7 +185,7 @@ typedef enum bfd_mach_o_load_command_type
> BFD_MACH_O_LC_ENCRYPTION_INFO_64 = 0x2c, /* Encrypted 64 bit seg info. */
> BFD_MACH_O_LC_LINKER_OPTIONS = 0x2d, /* Linker options. */
> BFD_MACH_O_LC_LINKER_OPTIMIZATION_HINT = 0x2e, /* Optimization hints. */
> - BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30 /* Minimal WatchOS version. */
> + BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30, /* Minimal watchOS version. */
> }
> bfd_mach_o_load_command_type;
>
> --
> 2.19.1
>
>