This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/20] Remove cleanups

On 2/14/19 6:48 AM, Tom Tromey wrote:
>>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
> 
> John> The only comment I have is that the structure names for exceptions look a
> John> bit awkward in code now with the mix of lower and upper case, e.g.:
> 
> That is a good point.  I think I can easily update the exception
> rewriter to also rename these classes.  I will take a look.  Plan B is
> to just have a second patch to do the renaming.

I think a second pass is fine unless its trivial to re-run the script.  I
second Pedro's suggestion about trying 'const' as well.

-- 
John Baldwin

                                                                            
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]