This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [amd64] Fix AMD64 return value ABI in expression evaluation
- From: "Leszek Swirski via gdb-patches" <gdb-patches at sourceware dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Leszek Swirski via gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 14 Feb 2019 16:07:43 +0100
- Subject: Re: [PATCH] [amd64] Fix AMD64 return value ABI in expression evaluation
- References: <20190214133507.38697-1-leszeks@google.com> <45c95dd6-7ea2-5428-c520-974452c6db89@redhat.com>
- Reply-to: Leszek Swirski <leszeks at google dot com>
On Thu, Feb 14, 2019 at 3:28 PM Pedro Alves <palves@redhat.com> wrote:
> I wonder whether this fixes PR gdb/24104,
> <https://sourceware.org/bugzilla/show_bug.cgi?id=24104>.
Doesn't look like it, nor would I expect it too -- all those functions
return ints after all. Anything after the first stack frame won't
matter.
> Generally looks good. Some minor comments below.
Thanks, new patch incoming. Apologies for the style violation churn,
I'm not that used to the GNU style guide.