This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][PATCH v2 PR gdb/21870] aarch64: Leftover uncleared debug registers
On 2/13/2019 3:40 AM, Pedro Alves wrote:
On 02/12/2019 01:10 AM, Weimin Pan wrote:
+clean_restart $testfile
+
+set test "run to exit"
+gdb_test_multiple "run" "$test" {
+ -re "exited with code 01.*$gdb_prompt $" {
+ pass "$test"
+ }
+ -re "exited normally.*$gdb_prompt $" {
+ pass "$test"
+ }
+}
A naked "run" command doesn't work when testing against
gdbserver with --target_board=native-gdbserver.
Is "run" important here? Could this use runto_main + "continue" instead?
As long as the test run doesn't assert, we could instead use
"runto_main + "continue". Thanks for pointing this out.
Also, the comment at the top of the file says:
# This test checks that GDB does not alter watchpoints set by an inferior.
# It sets a watchpoint on memory then writes to the watched memory.
# It will exit with 1 if the watchpoint is not reached.
But I couldn't spot where that "exit with 1" happens in the .c file.
You are right, it should be "exit with 2".
Also, when that happens, we're issuing a pass, as seen above.
Is that intended?
"Exit with 1" could happen if the PTRACE_SETREGSET call should
fail which is ok as long as it doesn't cause assertion.
Thanks for your comments.
Thanks,
Pedro Alves