This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/8] C++-ify ravenscar_arch_ops


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> This turns ravenscar_arch_ops into an abstract base class and updates
>> all the places where it is used.  This is an improvement because it
>> avoids any possibility of forgetting to set one of the function
>> pointers.  It also makes clear that these functions aren't intended to
>> be changed dynamically.

Pedro> LGTM, though I'd probably eliminate the prepare_to_store method or
Pedro> make it not-abstract -- seems that no architecture does anything with it.

I had noticed that as well, but decided to leave it in on the theory
that maybe it is good to keep the interfaces "parallel".  But, I don't
think it matters all that much, because if it is needed in the future,
it's easy enough to add it.  So, I'll remove it.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]