This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name.
- From: Richard Bunt <Richard dot Bunt at arm dot com>
- To: Paweł Wódkowski <pwodkowski at pl dot sii dot eu>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Wed, 30 Jan 2019 11:10:04 +0000
- Subject: Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name.
- References: <1542663530-140490-1-git-send-email-pwodkowski@pl.sii.eu> <1542663530-140490-3-git-send-email-pwodkowski@pl.sii.eu> <88ec6786-8834-7da2-207a-7392fd657e41@arm.com> <53cac622aea64147b2c1cd25feb16bdd@pl.sii.eu> <687ae24a-511f-1d32-025d-3c1e996a8e28@arm.com> <6a36a05571e94d01aafa6735e9f194ef@pl.sii.eu> <eed00342-2cdf-d3de-ba89-d76f28eac09a@arm.com> <ebc128ceeea3426f9397e30b2e2a21a5@pl.sii.eu>
Mail tends to drop off the top of the list pretty quickly, so please
keep pinging to help move the work along:
> The generally accepted ping frequency is 2 weeks after first submission,
> and every week thereafter.
https://sourceware.org/gdb/wiki/ContributionChecklist (13)
Many thanks,
Rich.
On 1/18/19 8:32 AM, Paweł Wódkowski wrote:
> On 2019-01-16 12:11, Richard Bunt wrote:
>> I have no further comments on v2 and look forward to v3.
>>
>> Many thanks,
>
> Great, I tough that this was forgotten ;)
>
> If you don't mind I will decouple this feature from unrelated patches
> in this series.
>
> I will send v3 shortly.
>
> Pawel
>
>>
>> Rich.
>>
>> On 12/9/18 8:40 PM, Paweł Wódkowski wrote:
>>> On 06.12.2018 16:02, Richard Bunt wrote:
>>>> Hi Paweł,
>>>>
>>>> I was testing with gfortran 7.3.0 and ifort 18.2. On the latter I observe
>>>> 2 kfails relating to the missing extends in the ptype output. However, this
>>>> is because I do not have patch 4 applied. I will take a closer look at this
>>>> patch with ifort 18.2 since I can analyze the implementation in action.
>>>>
>>>
>>> Ok, will wait (perhaps Wednesday) with v3. Pls, let know if there is
>>> something more to change.
>>>
>>> btw, I have ifort 19.0.1.144 20181018
>>>
>>>
>>>> On 12/4/18 9:05 PM, Paweł Wódkowski wrote:
>>>>
>>>>>>> +gdb_test "whatis wp_vla" "type = <not allocated>"
>>>>
>>>> A small nit while I'm here:
>>>> GDB tests needs to be uniquely identifiable, see https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
>>>>
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! After value assignment
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! Before vla allocation
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp%point%coo
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp_vla(1)%point%coo
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point%coo
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point%coo
>>>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp
>>>> 2 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp_vla
>>>>
>>>>
>>>
>>> Thx for the link. I will fix this.
>>>
>>> Pawel
>>>
>>>> Many thanks,
>>>>
>>>> Rich.
>>>>
>>>
>>
>